Cut ScopeConsumer #9995
Merged
Cut ScopeConsumer #9995
+26
β49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is only used by the NamesConsumer. It adds an extra level of indirection, but without providing any clear benefit.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9995 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18946 18937 -9
==========================================
- Hits 18152 18143 -9
Misses 794 794
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 881c8a1 |
Pierre-Sassoulas
added
the
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ScopeConsumerclass is only used by theNamesConsumer. It adds an extra level of indirection, but without providing any clear benefit. Cut it and incorporate its fields directly intoNamesConsumer.